Skip to content

fix(cc-widgets): update station login component to use international dialing prop#654

Merged
zachraymer merged 16 commits intowebex:nextfrom
zachraymer:next
Mar 17, 2026
Merged

fix(cc-widgets): update station login component to use international dialing prop#654
zachraymer merged 16 commits intowebex:nextfrom
zachraymer:next

Conversation

@zachraymer
Copy link
Contributor

@zachraymer zachraymer commented Mar 16, 2026

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7303

This pull request addresses

International dialing is now a station login prop so that consuming applications can use ff gating to enable
< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

Adds the internationaDialNumber prop to station login component
Changes the dial number regex logic to use international format if passed as prop
Falls back to agent config regex or US format
< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@zachraymer zachraymer requested a review from brain-frog March 16, 2026 17:49
@zachraymer zachraymer requested a review from a team as a code owner March 16, 2026 17:49
@zachraymer zachraymer changed the title chore: (cc-widgets): update station login component to use international dialing prop fix(cc-widgets): update station login component to use international dialing prop Mar 16, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1e59fef407

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-654.d1b38q61t1z947.amplifyapp.com

@zachraymer zachraymer requested a review from brain-frog March 16, 2026 18:08
Copy link
Contributor

@mkesavan13 mkesavan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Kindly add this toggle to sample app
  • Add a tiny VidCast of testing this change

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4dcaa28f9b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zachraymer
Copy link
Contributor Author

https://app.vidcast.io/share/1d2fd0d0-c8cd-4c14-ae91-7cb84704fc73?playerMode=vidcast
Vidcast showing samples app toggle and functionality

@zachraymer zachraymer requested a review from mkesavan13 March 16, 2026 18:48
@zachraymer zachraymer added the validated Indicates that the PR is ready for actions label Mar 16, 2026
@mkesavan13 mkesavan13 added the run_e2e Add this label to run E2E test for meeting and CC widgets label Mar 17, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f98737c56

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@zachraymer zachraymer merged commit 0cd6188 into webex:next Mar 17, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants