Skip to content

fix(store): fixes after bug bash#691

Merged
Shreyas281299 merged 3 commits into
webex:task-refactorfrom
Shreyas281299:fix-task-refactor
Jun 2, 2026
Merged

fix(store): fixes after bug bash#691
Shreyas281299 merged 3 commits into
webex:task-refactorfrom
Shreyas281299:fix-task-refactor

Conversation

@Shreyas281299
Copy link
Copy Markdown
Contributor

@Shreyas281299 Shreyas281299 commented Jun 1, 2026

COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7994 (Bug Bash fixes)

This pull request addresses

Task-refactor regressions found during bug bash in consult/conference flows:

  • stale consult leg data could show an older consulted agent
  • consult state data was not fully cleared after consult ended
  • participants list could disappear in conference+consult transitions
  • on-hold banner/timer could appear incorrectly when main leg should not be treated as held

by making the following changes

  • Updated consult media resolution to prefer the latest consult leg instead of the first matching media entry.
  • Added consult-end cleanup to reset consult-specific state (destination, queue consult state, consult timer/name context).
  • Updated call-control hold-state derivation in conference/consult flows to avoid false hold state for consulted agents.
  • Updated hold-timer derivation to avoid showing hold timer from active-leg signal for consulted-agent scenarios.
  • Updated CallControlCAD participants list visibility to be driven by participant count (>2 total participants), not exitConference control visibility.
  • Added/updated CallControlCAD tests for participant-list visibility behavior.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
  • Manual validation with task payload reproduction (taskData.json) for consult/conference hold-state behavior.
  • yarn workspace @webex/cc-store test:styles
  • yarn workspace @webex/cc-task test:styles
  • yarn workspace @webex/cc-components test:styles
  • yarn workspace @webex/cc-components test:unit (currently fails due existing test-fixture issue: createEnabledMainTaskUIControls/createMockTaskUIControls not exported as expected in this environment)

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
      • Cursor AI Assistant
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@Shreyas281299 Shreyas281299 requested a review from a team as a code owner June 1, 2026 07:22
@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-691.d1b38q61t1z947.amplifyapp.com

Shreyas281299 and others added 2 commits June 1, 2026 17:58
Update @webex/contact-center from task-refactor.6 to task-refactor.7 in store dependencies and lockfile so this branch uses the latest SDK fixes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Shreyas281299 Shreyas281299 merged commit cb89e5f into webex:task-refactor Jun 2, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant