fix(task-refactor): bug bash fixes by akulakum · Pull Request #692 · webex/widgets

akulakum · 2026-06-02T11:35:30Z

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

Contact Center Call Control regressions in the task-refactor build around hold state, consult timers, and conference participant list visibility during multi-party flows.

Hold & consult timer issues

Agent 2 (consulted side): main CAD “On Hold” chip and timer were wrong or reset after refresh in consult flows (agent-name, EP/DN, conference nested consult).
Agent 1 (initiator side): during EP/DN consult, switching from consult back to main showed “Consulting” with the wrong timer instead of “Consult on Hold” when the consult leg was parked.
Hold timestamps from the backend could arrive in seconds or milliseconds, causing incorrect elapsed times.

Conference participant list issues

During conference, when Agent 1 consults a third agent, the “+N Participant” list disappeared on Agent 1’s side after the consult was accepted.
The consulted agent (Agent 3) incorrectly saw the conference participant list even though they are not on the conference mainCall leg.
Plain conference (Agent 1 + Agent 2 + customer) participant list needed to remain stable before and during nested consult.

by making the following changes

Hold logic (main CAD chip + timer)

Extracted hold derivation into main-cad-hold.util.ts (deriveMainCadHoldState) with rules for EP/DN consulted agent, agent-name consulted agent, nested consult, and plain conference hold.
Added resolveMainCadHoldTimestampMs and sessionStorage hold anchors in task-util.ts / useHoldTimer.ts so hold timers survive page refresh when backend timestamps lag.
Added normalizeHoldTimestampMs to normalize second vs millisecond hold timestamps.

Consult leg timer (Agent 1 initiator CAD)

Updated calculateConsultTimerData in timer-utils.ts to treat consult on hold from consultMedia.isHold without requiring holdTimestamp > 0.
Prefer fresher snapshot interaction for initiator on leg switch; fallback when activeLeg === 'main' and consult controls are visible during media lag.
Added consult hold session anchor via resolveConsultHoldTimestampMs and anchor read/write in helper.ts.

Conference participant list

Fixed getConferenceParticipants in store/task-utils.ts to resolve mainCall media explicitly during nested consult (when interactionId points at the consult leg).
Return empty participants for consult-only agents not present on mainCall media; always exclude EP/DN secondary consult child tasks.
Updated CallControlCAD visibility to treat interaction.state === 'conference' as active conference (not only exitConference.isVisible), while still requiring non-empty participant data and excluding consult-only agents.

Quality

Added/updated unit tests for hold, consult timer, and participant list scenarios.
Removed any from new utils code; fixed failing helper tests and lint (test:cc-widgets, test:styles passing).

Change Type

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Tooling change
Internal code refactor

The following scenarios were tested

The testing is done with the amplify link
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

I have not skipped any automated checks
All existing and new tests passed
I have updated the testing document
I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3dee3c13ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-02T11:39:13Z

+  const heldEntries = consultEntries.filter((media) => media.isHold === true);
+  const candidates = heldEntries.length > 0 ? heldEntries : consultEntries;


Stop preferring stale held consult legs

When a previous consult leg remains in interaction.media with isHold: true and the agent starts a new consult whose newer consult media is not held, this filter discards the newer leg before the recency comparison runs. In that re-consult scenario calculateConsultTimerData will keep using the stale held media and show Consult on Hold with the old timestamp even though the current consult is active; compare recency across all consult entries first, then derive hold state from the selected current leg.

Useful? React with 👍 / 👎.

aws-amplify-us-east-2 · 2026-06-02T11:41:02Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-692.d1b38q61t1z947.amplifyapp.com

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0997f74b68

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T10:37:54Z

+  const agentId = currentTask?.data?.agentId;
+  const selfConsultState = agentId && currentTask?.data?.interaction?.participants?.[agentId]?.consultState;


Pass the real agent id into consult phase detection

When the SDK does not set data.consultStatus and the switch-control fallback is not in the disabled state, pending consult detection depends on reading the current participant's consultState; however currentTask.data.agentId is not populated by the task/store code (the component already receives agentId as a prop), so selfConsultState stays undefined. In that consult-requested state this falls through to active, causing filterButtonsForConsultation to hide the main transfer button that this change is trying to keep visible until the consulted party joins.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb05919b43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-04T14:39:06Z

+    if (nextConsultLabel === TIMER_LABEL_CONSULT_ON_HOLD) {
+      writeConsultHoldAnchor(interactionId, nextConsultTimestamp);


Refresh consult hold anchor when backend timestamp arrives

When an EP/DN consult switches to main before the SDK has populated holdTimestamp, calculateConsultTimerData now returns Consult on Hold using the Date.now()/session fallback, and this line persists that fallback. If the same consult media later receives the real holdTimestamp while isHold, mediaResourceId, and consultState stay unchanged, this effect's dependency list does not re-run, so the consult timer remains anchored to the local fallback instead of the backend event time. Include the consult media holdTimestamp as a primitive dependency or avoid persisting fallback timestamps as final anchors.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1108467a51

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-06-05T08:23:59Z

+  const latestTaskData = taskWithSnapshot.state?.context?.taskData;
+  const snapInteraction = latestTaskData?.interaction;
+  const dataInteraction = currentTask.data?.interaction as InteractionWithMedia | undefined;
+  const participant = dataInteraction?.participants?.[agentId] ?? snapInteraction?.participants?.[agentId];


Use the snapshot participant with snapshot consult data

When the initiator's state-machine snapshot is fresher than currentTask.data (the case handled by preferring snapInteraction for Agent 1), this still takes the participant from dataInteraction first. If currentTask.data still has consultState: 'consultInitiated' or lacks the new consultTimestamp while state.context.taskData already has the accepted consult, calculateConsultTimerData uses the stale participant and returns Consult Requested/timestamp 0 instead of the snapshot's active or held consult timer on switch-to-main. Pick the participant from the same interaction selected for the consult phase.

Useful? React with 👍 / 👎.

fix(task-refactor): bug bash fixes

3dee3c1

akulakum requested a review from a team as a code owner June 2, 2026 11:35

akulakum added the validated Indicates that the PR is ready for actions label Jun 2, 2026

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

fix(task-refactor): multi login syncing issue

0997f74

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

fix(task-refactor): fix pause button with on hold timer issue

bb05919

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Shreyas281299 approved these changes Jun 5, 2026

View reviewed changes

fix(task-refactor): update SDK version for the syncing issues

1108467

chatgpt-codex-connector Bot reviewed Jun 5, 2026

View reviewed changes

akulakum merged commit 01bd548 into webex:task-refactor Jun 5, 2026
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(task-refactor): bug bash fixes#692

fix(task-refactor): bug bash fixes#692
akulakum merged 4 commits into
webex:task-refactorfrom
akulakum:NEW_BUGS_TASK_REFACTOR

akulakum commented Jun 2, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Uh oh!

aws-amplify-us-east-2 Bot commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const heldEntries = consultEntries.filter((media) => media.isHold === true);
		const candidates = heldEntries.length > 0 ? heldEntries : consultEntries;

		const agentId = currentTask?.data?.agentId;
		const selfConsultState = agentId && currentTask?.data?.interaction?.participants?.[agentId]?.consultState;

		if (nextConsultLabel === TIMER_LABEL_CONSULT_ON_HOLD) {
		writeConsultHoldAnchor(interactionId, nextConsultTimestamp);

Conversation

akulakum commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

by making the following changes

Change Type

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

Checklist before merging

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 2, 2026

Choose a reason for hiding this comment

Uh oh!

aws-amplify-us-east-2 Bot commented Jun 2, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

akulakum commented Jun 2, 2026 •

edited

Loading