Skip to content

fix: verify e2e tests after updating machine config#708

Merged
riteshfyi merged 8 commits into
webex:temp_test_e2efrom
riteshfyi:update_pw
Jun 29, 2026
Merged

fix: verify e2e tests after updating machine config#708
riteshfyi merged 8 commits into
webex:temp_test_e2efrom
riteshfyi:update_pw

Conversation

@riteshfyi

Copy link
Copy Markdown
Contributor

COMPLETES #NA

E2E tests are crashing, this is to check if updating the machine config resolves the issue

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Cursor
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@riteshfyi riteshfyi requested a review from a team as a code owner June 29, 2026 05:52
@riteshfyi riteshfyi added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Jun 29, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad7f48a329

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/pull-request.yml Outdated
e2e_test_cc_widgets:
timeout-minutes: 50
runs-on: ubuntu-latest
runs-on: ubuntu-latest-4-core

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the valid 4-core runner label

If this is intended to target GitHub's default 4-core larger Ubuntu runner, the label is misspelled: GitHub lists the 4-core Ubuntu label as ubuntu-latest-4-cores (plural) in its larger-runner announcement (https://github.blog/changelog/2022-10-20-github-actions-larger-hosted-runners-are-now-automatically-created-for-customers/). With the singular ubuntu-latest-4-core, the e2e_test_cc_widgets job will remain queued or fail to find a matching runner whenever the run_e2e label triggers it, unless the organization has created a custom runner with exactly this nonstandard label.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks goat

@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Jun 29, 2026
@riteshfyi riteshfyi merged commit 8a9ea97 into webex:temp_test_e2e Jun 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_e2e Add this label to run E2E test for meeting and CC widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant