fix: verify e2e tests after updating machine config#708
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad7f48a329
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| e2e_test_cc_widgets: | ||
| timeout-minutes: 50 | ||
| runs-on: ubuntu-latest | ||
| runs-on: ubuntu-latest-4-core |
There was a problem hiding this comment.
Use the valid 4-core runner label
If this is intended to target GitHub's default 4-core larger Ubuntu runner, the label is misspelled: GitHub lists the 4-core Ubuntu label as ubuntu-latest-4-cores (plural) in its larger-runner announcement (https://github.blog/changelog/2022-10-20-github-actions-larger-hosted-runners-are-now-automatically-created-for-customers/). With the singular ubuntu-latest-4-core, the e2e_test_cc_widgets job will remain queued or fail to find a matching runner whenever the run_e2e label triggers it, unless the organization has created a custom runner with exactly this nonstandard label.
Useful? React with 👍 / 👎.
COMPLETES #NA
E2E tests are crashing, this is to check if updating the machine config resolves the issue
< DESCRIBE THE CONTEXT OF THE ISSUE >
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.