Fix review feedback from PR #6: swimlane semantics, typo, null handling, Markdown table#7
Merged
ReneSchwarzer merged 2 commits intodevelopfrom Apr 2, 2026
Merged
Conversation
…ng, and Markdown formatting Agent-Logs-Url: https://github.com/webexpress-framework/WebExpress.WebUI/sessions/1636dcff-9fa7-4a2f-ae04-5aa71e2ee9a1 Co-authored-by: ReneSchwarzer <31061438+ReneSchwarzer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update npm dependencies for better performance
Fix review feedback from PR #6: swimlane semantics, typo, null handling, Markdown table
Apr 2, 2026
ReneSchwarzer
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses four code review comments on the 0.0.10-alpha PR targeting test correctness, naming clarity, and documentation formatting.
Changes
ControlKanbanSwimlane: RenameCollapsed→Expanded(constructor param + property). Rendering now emitsdata-expanded="true"when expanded,nullotherwise — inverting the oldCollapsed ? "false" : nulllogic so the attribute name and value are semantically consistent.UnitTestControlKanban.AddSwimlane: Update expected HTML todata-expanded="true"to match the corrected swimlane semantics.UnitTestControlFixture: Fix method name typoCreratePageContextMock→CreatePageContextMockat both declaration and call site. Remove duplicate</param>in XML doc.UnitTestControlListItemButton: Replace unconditionalnew ActionModal(modal)withstring.IsNullOrWhiteSpace(modal) ? null : new ActionModal(modal)for bothPrimaryActionandSecondaryAction— explicitly signals "no action" for the null test case rather than relying onActionModal's internal null guard.docs/js/tree.md: Reformat node attribute table to canonical GFM syntax (leading/trailing pipes,| --- |separator row).