refactor: implement runLater functionality with event handling instead of long polling#1041
Merged
Conversation
…d of long polling
hyyan
added
the
Type: Refactor
github-actions
Bot
added
the
module: foundation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the runLater functionality by replacing the long polling mechanism with event-driven handling for processing background thread requests. The changes improve efficiency by eliminating the need for continuous polling.
- Replaces timer-based polling with custom event posting and handling
- Changes request IDs from integers to strings for better uniqueness
- Adds proper event callback registration and cleanup
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
EnvironmentRunLaterEventHandler.java |
New event handler class for processing runLater custom events |
EnvironmentAccessRequest.java |
Changes request ID type from int to String |
Environment.java |
Refactors runLater implementation to use event posting instead of polling timer |
EnvironmentRunLaterTest.java |
Updates tests to cover new event-driven functionality and edge cases |
Contributor
Code Coverage
Files
|
…erTest.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.