Skip to content

Kotlin/terminal#1298

Merged
hyyan merged 6 commits into
mainfrom
kotlin/terminal
Apr 13, 2026
Merged

Kotlin/terminal#1298
hyyan merged 6 commits into
mainfrom
kotlin/terminal

Conversation

@cliebhardt

Copy link
Copy Markdown
Collaborator

No description provided.

@cliebhardt cliebhardt self-assigned this Mar 31, 2026
@cliebhardt cliebhardt requested a review from hyyan as a code owner March 31, 2026 11:23
@github-actions github-actions Bot added POM The change modifies the POM files module: kotlin The change is in the Kotlin module labels Mar 31, 2026
@github-actions

github-actions Bot commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 1 package(s) with unknown licenses.
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1c20a57.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

License Issues

webforj-kotlin/pom.xml

PackageVersionLicenseIssue Type
com.webforj:webforj-terminal26.00-SNAPSHOTNullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
maven/com.webforj:webforj-terminal 26.00-SNAPSHOT UnknownUnknown

Scanned Files

  • webforj-kotlin/pom.xml

@hyyan hyyan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Missing @WebforjDsl annotations on receiver and block types
  2. webforj-terminal dependency should be <optional>true</optional> (like webforj-googlecharts)
  3. root.terminal() (no block) won't compile, it is Missing = {} default on block parameter

@cliebhardt cliebhardt requested a review from hyyan April 13, 2026 09:26
@hyyan hyyan merged commit 393cfc3 into main Apr 13, 2026
5 checks passed
@hyyan hyyan deleted the kotlin/terminal branch April 13, 2026 10:54
@sonarqubecloud

Copy link
Copy Markdown

@hyyan hyyan added this to the 26.00 milestone Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: kotlin The change is in the Kotlin module POM The change modifies the POM files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants