webgpu.h: Fix WGPU_WHOLE_SIZE causing linking errors.#34
Merged
Kangz merged 1 commit intowebgpu-native:masterfrom Feb 10, 2020
Merged
webgpu.h: Fix WGPU_WHOLE_SIZE causing linking errors.#34Kangz merged 1 commit intowebgpu-native:masterfrom
Kangz merged 1 commit intowebgpu-native:masterfrom
Conversation
The symbol was not marked as static and would cause linking errors because it would be defined in multiple translation units. Replace it with a more traditional C-style #define. Found by @floooh.
Collaborator
|
would adding |
|
|
Collaborator
Author
|
@kvark given the above, WDYT of using the |
kvark
approved these changes
Feb 8, 2020
Collaborator
kvark
left a comment
There was a problem hiding this comment.
I don't have a strong preference here, we can proceed :)
Perhaps, somewhere close to MVP we can call some people who know what idiomatic C is, to review the header API.
Collaborator
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The symbol was not marked as static and would cause linking errors
because it would be defined in multiple translation units. Replace it
with a more traditional C-style #define.
Found by @floooh.