Require use of the bitflag registry; improve bitflag docs#493
Merged
kainino0x merged 2 commits intowebgpu-native:mainfrom Jan 17, 2025
Merged
Require use of the bitflag registry; improve bitflag docs#493kainino0x merged 2 commits intowebgpu-native:mainfrom
kainino0x merged 2 commits intowebgpu-native:mainfrom
Conversation
lokokung
approved these changes
Jan 13, 2025
| * For reserved non-standard bitflag values, see @ref BitflagRegistry. | ||
| */ | ||
| typedef WGPUFlags WGPUBufferUsage; | ||
| /** |
Collaborator
There was a problem hiding this comment.
nit. These all seem really redundant, given that its documented in the code right below. Is it for doc generation that this is necessary?
Collaborator
Author
There was a problem hiding this comment.
You're right it's pretty redundant. Turns out the docs do show the definition:
unlike for enums:
Of course this html view is not the only possible way to look at things. But maybe the only useful docs are special cases like 0 and Red|Green|Blue|Alpha. Will follow up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #490
(dawn bug https://crbug.com/389099883)