Simplify WGPUWaitStatus "Unsupported" cases#499
Merged
kainino0x merged 4 commits intowebgpu-native:mainfrom Jan 25, 2025
Merged
Simplify WGPUWaitStatus "Unsupported" cases#499kainino0x merged 4 commits intowebgpu-native:mainfrom
kainino0x merged 4 commits intowebgpu-native:mainfrom
Conversation
lokokung
approved these changes
Jan 16, 2025
kainino0x
commented
Jan 18, 2025
Collaborator
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
Like this is fine, but I feel kinda bad removing information from the user
4 tasks
kainino0x
force-pushed
the
waitstatus-error
branch
from
c75e8bb to
854071c
Compare
Collaborator
Author
|
If users need this at runtime I think it's better if they just have a way to check the actual capabilities and not use trial-and-error. Filed #503 about reflecting the instance capabilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mentioned
WGPUWaitStatusin #401 but I didn't think about simplifying it so we didn't discuss it.Since we're relying now on "implementation-defined logging" to convey details we don't generally need detailed error codes for things that are just surface-level misuses of the API.
In
WGPUWaitStatuswe have threeUnsupportedcases:WGPUWaitStatus_UnsupportedTimeoutWGPUWaitStatus_UnsupportedCountWGPUWaitStatus_UnsupportedMixedSourcesI don't think these are cases that a program would actually respond to programmatically. So I'm proposing we simplify into just one
WGPUWaitStatus_UnsupportedorWGPUWaitStatus_Error, with implementation-defined logging.I used
WGPUWaitStatus_Errorhere.