Renames PopErrorScopeStatus Error to EmptyStack.#519
Closed
lokokung wants to merge 1 commit intowebgpu-native:mainfrom
Closed
Renames PopErrorScopeStatus Error to EmptyStack.#519lokokung wants to merge 1 commit intowebgpu-native:mainfrom
lokokung wants to merge 1 commit intowebgpu-native:mainfrom
Conversation
cwfitzgerald
approved these changes
Mar 10, 2025
Collaborator
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
STATUS_OK_STACK_UNDERFLOW
Collaborator
|
I thought we decided to rename EmptyStack to Error so that it would be more generic? #369 is already closed. |
Collaborator
Author
|
Oh, hmm, that might be true actually... Lemme dig through the notes to verify then. Could definitely be outdated on Dawn side instead of this one. EDIT: Yea, I just read the bug again and the last note there is to rename it to Error. Dropping this change then and I'll update it in Dawn. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #369