Use Undefined for enums when it's explicitly defined.#548
Merged
kainino0x merged 2 commits intowebgpu-native:mainfrom Jun 18, 2025
Merged
Use Undefined for enums when it's explicitly defined.#548kainino0x merged 2 commits intowebgpu-native:mainfrom
kainino0x merged 2 commits intowebgpu-native:mainfrom
Conversation
kainino0x
reviewed
Jun 17, 2025
Collaborator
Author
|
That would work, yes, but that is harder to maintain atm since ensuring that we include the default values in those cases is hard. The change will ensure that even if we forget to include the default value, that we will use undefined. I can also update the existing ones to add the default, but I think that doing it programmatically will be more future-proof. |
kainino0x
reviewed
Jun 17, 2025
Collaborator
kainino0x
left a comment
There was a problem hiding this comment.
SG, one comment then.
Collaborator
|
Also it would be nice to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.