feat(admin): validate requests based on OpenAPI #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 90 files with indirect coverage changes 🚀 New features to boost your workflow:
|
vm-001
force-pushed
the
feat/openapi-validator-v2
branch
3 times, most recently
from
30f942c to
ea39177
Compare
cchenggit
requested changes
Jul 23, 2025
pkg/openapi/openapi.go
Outdated
| case *openapi3.SchemaError: | ||
| node := validateErr.Fields | ||
| fields := se.JSONPointer() | ||
| for i, field := range fields { |
Collaborator
There was a problem hiding this comment.
consider array type invalid, for example attempts: [0, "123", 30], error msg will be {"attempts":[null,"value must be an integer"]}, need a test case.
vm-001
force-pushed
the
feat/openapi-validator-v2
branch
3 times, most recently
from
ac3caf9 to
e821f62
Compare
cchenggit
reviewed
Jul 25, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vm-001
force-pushed
the
feat/openapi-validator-v2
branch
from
da40019 to
01c4de8
Compare
cchenggit
reviewed
Jul 27, 2025
Co-authored-by: cchenggit <cchenggit@users.noreply.github.com> Signed-off-by: Yusheng Li <leeys.top@gmail.com>
Closed
cchenggit
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the OpenAPI Specification. Ideally, the spec should become the source of truth. However, the validation for the Plugin and its configuration is not flexible enough, and we must retain manual validation until OpenAPI 3.1.0 is supported.
issue #145
Benchmark
Roughly, using JSONSchema validation is about twice as slow as go-playground/validator(via reflection).