[TASK] convert deploy app to plugin #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kyungmi
commented
Nov 12, 2015
kyungmi
commented
- create new deploy plugin
- documentation (README.md)
- fix some resource url bugs
- internationalization
added 4 commits
November 12, 2015 23:03
[DESC.] - convert system app to plugin - add this plugin to `plugin-settings.json` file
[DESC.] - add `baseUrl` property to the `app-config` module - fix widget's templates using `app-config`
Member
There was a problem hiding this comment.
I think it's needless to define i18n as Constants.
the i18n object play a role as Constants.
국제화를 상수로 다시 정의할 필요가 없어보입니다.
그 자체로 이미 상수 역할을 하고 있습니다.
바로 사용하는 것이 좋아 보입니다.
Contributor
Author
There was a problem hiding this comment.
기존 소스에서 컨버팅하는 데 드는 비용을 줄이려고 저렇게 작성했는데, 바꾸도록 하겠습니다.
Member
|
아울러 새로 올라가는 파일들에 대해서는 Coding Convention 적용 부탁 드립니다. |
hwshim
added a commit
that referenced
this pull request
Nov 16, 2015
[TASK] convert deploy app to plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.