refactor: dot prop delete mutable#14
Merged
Merged
Conversation
dot-prop's deleteProperty already handles array slots via string keys, but our type signature only accepted Record + string. Add a function overload that accepts T[] + number so callers can pass a numeric index directly. Delegates to dot-prop (sparse hole, not splice). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tests Both immutableDelete and mutableDelete now accept a numeric index when the target is an array, splicing the element out (matching dot-prop-immutable behaviour). Tests split from a single file into __tests__/dotProp/ with one file per function. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.