feat(tasks): self cleaning tasks#5121
Merged
brunozoric merged 18 commits intonextfrom Apr 29, 2026
Merged
Conversation
brunozoric
force-pushed
the
bruno/feat/tasks/self-cleaning-tasks
branch
from
3555370 to
62fd37e
Compare
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Implements recursive best-effort deletion of a task subtree (task + descendants + their logs when databaseLogs=true), wired into createTaskCrud as context.tasks.cleanupTaskSubtree(id). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… to ApiContext Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds 5 integration tests covering all selfCleanup scenarios (onSuccess, onError, always, parent cascade, onAbort). Also fixes a bug in RunnableTaskDecorator where selfCleanup was not forwarded to the SelfCleaningTaskDecorator, causing cleanup to never trigger. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Integration: onError cleanup, array form, user-hook ordering, 3-level cascade, mixed databaseLogs in cascade, explicit never. - Unit: cleanupTaskSubtree cycle guard. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brunozoric
force-pushed
the
bruno/feat/tasks/self-cleaning-tasks
branch
from
b8171f3 to
9884d3a
Compare
Remove the context-in-ITaskLifecycleHook approach (Tasks 1 & 2) and replace with the CleanupTaskSubtreeUseCase UseCase/DI pattern that was actually implemented. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR gives a task to self-delete after it is done. If turned on, it will delete everything in the database related to that task: run, logs, child tasks, their logs....
It is configurable via the regular task definition.
How Has This Been Tested?
Jest and manually.