fix: add distinctId support to the Node client#8
Merged
Conversation
The Node WTS client always read or minted `user.id` in ~/.webiny/config and had no way to use an externally-owned machine id. The Webiny admin and the website install/finish alias both key off the canonical @webiny/global-config top-level `id`, while the CLI used a separate `user.id` UUID — fragmenting funnels across CLI/admin/website. Add an optional `distinctId` to NodeClientConfig (mirroring the web client's fixedId). When provided it is used as-is and the config file is left untouched. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 3.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node WTS client always read or minted
user.idin ~/.webiny/config and had no way to use an externally-owned machine id. The Webiny admin and the website install/finish alias both key off the canonical @webiny/global-config top-levelid, while the CLI used a separateuser.idUUID — fragmenting funnels across CLI/admin/website.Add an optional
distinctIdto NodeClientConfig (mirroring the web client's fixedId). When provided it is used as-is and the config file is left untouched.