Improve regex pattern for parsing ban entries#14
Merged
giftkugel merged 1 commit intowebishdev:mainfrom Apr 18, 2026
Merged
Conversation
Adjusted the whitespace handling in the first part of the regex and allowed for negative numbers in the ban duration part.
There was a problem hiding this comment.
Pull request overview
This PR updates the ban-entry parsing logic in GetBanned to better match the actual fail2ban-client --with-time output seen in logs, reducing “Failed to parse ban entry” errors.
Changes:
- Updated the ban-entry regex to accept multiple spaces/tabs after the IP address.
- Updated the ban-entry regex to accept negative duration values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Thank you for the contribution @gentges 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for building this tool I really appreciate it!
While I was trying to fix some connection issues on my server I also looked at the container logs running this image and I noticed a lot of entries like this one:
These were coming from my ufw rule, but when I fetched the banned ips for another rule I got a similar looking entry:
Both of these ban entries would not match the regex before the error position.
I updated the regex to allow for multiple spaces and/or tabs after the ip address and also allow for negative numbers in the duration.