test(e2e): update stale data-layout assertion to wj:children markers#32
Merged
Conversation
The e2e test 'layout renders a data-layout wrapper around page content' was authored 2026-04-19 (52cb33f). The framework switched from a single [data-layout] wrapper attribute to per-layout <!--wj:children:<segment>--> comment markers on 2026-05-16 (f216f0e). The test wasn't updated; nobody noticed because the e2e suite is gated behind WEBJS_E2E=1 and doesn't run in regular CI. Updates the assertion to look for the comment markers via NodeIterator + SHOW_COMMENT. Verifies marker presence + the same <header>/<main> structural assertions as before. Verified: WEBJS_E2E=1 node --test --test-name-pattern="wj:children" test/e2e.test.mjs passes (1/1). Unrelated to the lit-API parity merge (#31); just unblocking the gated suite from showing a false failure on the next run.
vivek7405
added a commit
that referenced
this pull request
May 21, 2026
…32) The e2e test 'layout renders a data-layout wrapper around page content' was authored 2026-04-19 (52cb33f). The framework switched from a single [data-layout] wrapper attribute to per-layout <!--wj:children:<segment>--> comment markers on 2026-05-16 (277dda2). The test wasn't updated; nobody noticed because the e2e suite is gated behind WEBJS_E2E=1 and doesn't run in regular CI. Updates the assertion to look for the comment markers via NodeIterator + SHOW_COMMENT. Verifies marker presence + the same <header>/<main> structural assertions as before. Verified: WEBJS_E2E=1 node --test --test-name-pattern="wj:children" test/e2e.test.mjs passes (1/1). Unrelated to the lit-API parity merge (#31); just unblocking the gated suite from showing a false failure on the next run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The e2e test
layout renders a data-layout wrapper around page contentwas authored on 2026-04-19. The framework switched from a single[data-layout]wrapper attribute to per-layout<!--wj:children:<segment>-->comment markers on 2026-05-16 (f216f0e). The test wasn't updated; nobody noticed because the e2e suite is gated behindWEBJS_E2E=1and doesn't run in regular CI.Surfaced as a 1/48 failure when I ran the gated suite as post-merge verification for #31.
Fix
Updates the test to walk the comment tree via
NodeIterator(document, SHOW_COMMENT)and assert presence of at least onewj:children:marker. Keeps the same<header>/<main>structural assertions.Test plan
WEBJS_E2E=1 node --test --test-name-pattern="wj:children" test/e2e.test.mjspasses (1/1)