Conversation
norbye
added
the
new-feature
norbye
force-pushed
the
manage-backend
branch
2 times, most recently
from
4ba49ea to
b700e1c
Compare
LudvigHz
left a comment
LudvigHz
left a comment
There was a problem hiding this comment.
Looks really good 💯
Not much to complain about :) 
| console.log(JSON.stringify(values, null, 2)); | ||
| setReturnedData(undefined); | ||
| const processedValues = { ...values }; | ||
| // Convert from iso to iso to re-add timezone data that input[type=datetime-local] removes |
There was a problem hiding this comment.
Could you just not use this input type? There has to be an easy way to use timezone-aware date inputs?
There was a problem hiding this comment.
Tried to find an alternative - but I had some trouble finding something good.. As far as I can tell there aren't really any good alternatives in native HTML5, so if not this then we'd have to add another dependency to sort it out
There was a problem hiding this comment.
Hmm yeah okay. Guess that's fine. But then it should be clear what timezone they are inputting here right? Or will luxon add the timezone stuff? (I guess also the comment isn't super clear 🙃 )
There was a problem hiding this comment.
Fair, I'll think of something to improve the comment. The way it works now is that Luxon takes the local timezone as default when running fromISO() and a timezone is not passed (as datetime-local does), and returns the ISO string including the timezon
There was a problem hiding this comment.
Updated it now to explicitly type out the default option variables that matter to make it a bit more readable what actually happens
2 participants
PR to enable the creation and editing of admissions from the website (should remove the need for shelling<3).
Tasks
Noteworthy stuffs
Smaller less noteworthy stuff
tl:dr; not perfect - but it works and I'd rather iterate on it over time
Visual preview
This is the backend of #857, with only minor changes to the frontend.
Fixes ABA-217, #6, #7