Support multiple labels #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reillyeon
requested changes
Dec 4, 2025
Member
|
@anssiko, can you add discussion of this PR to the next F2F agenda? |
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
reillyeon
approved these changes
Dec 11, 2025
tomayac
reviewed
Dec 15, 2025
| unsigned long long endIndex; | ||
| DOMString correction; | ||
| CorrectionType type; // exists if proofreader.includeCorrectionTypes === true | ||
| sequence<CorrectionType> type; // exists if proofreader.includeCorrectionTypes === true |
Contributor
There was a problem hiding this comment.
Should this be renamed to types then? (@christianliebel had the same doubts.)
Contributor
There was a problem hiding this comment.
@reillyeon Since you approved the PR, did you approve it with the assumption of this suggestion to be applied?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the API shape to support multiple labels per correction.
Please see the open issue for detailed discussion: #30