Open
Conversation
bwalderman
requested changes
Mar 19, 2026
| |registered tool|'s [=tool definition/execute steps=] is prepared to run, then set |matches| to | ||
| false. | ||
|
|
||
| 1. Let |tool read-only hint| be true if |tool|'s {{ModelContextTool/annotations}} [=map/exists=] and |
Collaborator
There was a problem hiding this comment.
Can we split out the annotation matching into a separate algorithm that this references? That should hopefully avoid issues where we add new annotations but forget to include them in the steps here.
Collaborator
Author
There was a problem hiding this comment.
Hmm, do you think it's less likely we'll forget to add checks there than here? I'm wondering if we should just factor out a more general matching algorithm for the whole tool, so everything can go in one place, instead of being spread across two places. How do you feel about that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR specifies the first proposal in #130, which is the simples to go with for now. That approach is pending working group agreement. See https://github.com/webmachinelearning/meetings/blob/main/telcons/2026-03-19-cg-agenda.md#-webmcp.
See https://crrev.com/c/7681371 for WPTs and Chromium implementation. (Note that the WPTs there are currently listed in an "internal" directory, but they will soon be moved "externally" to appear in https://github.com/web-platform-tests/wpt).
Fixes #130.