Skip to content

Fix output sequence issue of lstm with backward direction and both direction #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
huningxin merged 7 commits into from
Jan 14, 2025
Merged

Fix output sequence issue of lstm with backward direction and both direction #123

huningxin merged 7 commits into from
Jan 14, 2025

Conversation

@BruceDai
Copy link
Contributor

@BruceDai BruceDai commented Jan 7, 2025

@fdwr @huningxin PTAL, thanks!

huningxin
huningxin reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@BruceDai BruceDai mentioned this pull request Jan 7, 2025
Closed
@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 7, 2025

Fixed comments in new commit, please take another look, thanks!

huningxin
huningxin approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fdwr
fdwr approved these changes Jan 7, 2025
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

huningxin
huningxin reviewed Jan 8, 2025
View reviewed changes
huningxin
huningxin reviewed Jan 8, 2025
View reviewed changes
@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 8, 2025

I prefer to reversing the concatenation in the algorithm steps than "fix" the wrong order after that.

Please take another look at the new commit, thanks! ☕

huningxin
huningxin approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits

@BruceDai
Copy link
Contributor Author

BruceDai commented Jan 9, 2025

Updated. Please take another look, thanks!

huningxin
huningxin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceDai BruceDai mentioned this pull request Jan 9, 2025
Merged
@BruceDai BruceDai changed the title Fix output sequence issue with backward direction and both direction Fix output sequence issue of lstm with backward direction and both direction Jan 9, 2025
fdwr
fdwr approved these changes Jan 9, 2025
View reviewed changes
Copy link

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@huningxin huningxin merged commit 47e6047 into webmachinelearning:main Jan 14, 2025
3 checks passed
@BruceDai BruceDai mentioned this pull request Jan 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huningxin huningxin huningxin approved these changes

+1 more reviewer

@fdwr fdwr fdwr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BruceDai @huningxin @fdwr