Bugfix: Add missing data type validations for QDQ ops#922
Bugfix: Add missing data type validations for QDQ ops#922huningxin merged 1 commit intowebmachinelearning:mainfrom
Conversation
Validate zeroPoint's data type is the same as input's for dequantizeLinear. Validate scale's data type is the same as input's for quantizeLinear. Fix: webmachinelearning#921
|
Was it not already covered by this step below? Anyway, tis fine to add explicitly to the steps.
|
I suppose it was not covered.
For example, zeroPoint data type is int32 which is allowed, while input data type is int8 which is different from zeroPoint's. |
|
But if dequantizeLinear's input is int32, then according to the table, zero point must be int32 too ("same as input"). So the extra check is redundant |
|
@reillyeon , please take a look, this PR aligns spec steps with Chromium implementation, see details in #921. |
|
@fdwr @reillyeon , thanks for the review and approvals. I am going to merge it. |
SHA: 32a1770 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Validate zeroPoint's data type is the same as input's for dequantizeLinear.
Validate scale's data type is the same as input's for quantizeLinear.
Fix: #921
Preview | Diff