Specify element count limit#926
Merged
fdwr merged 1 commit intowebmachinelearning:mainfrom Mar 27, 2026
Merged
Conversation
fdwr
approved these changes
Mar 25, 2026
Collaborator
fdwr
left a comment
fdwr
left a comment
There was a problem hiding this comment.
👍
This limits tensors to 2 billion elements, which I think is okay because I haven't seen a single tensor approach that anyway (though, seen quite a few hundred million element tensors). There's my "640KB ought to be enough for anyone" future quote 😅.
mwyrzykowski
approved these changes
Mar 26, 2026
Collaborator
|
Are we waiting on review from anyone else to merge? Reilly maybe? (otherwise I'd just merge it) |
Contributor
Reilly is OOO, +1 to merge. |
Member
|
Feel free to proceed with merge. As discussed, If new information becomes available in the future, we can revise. |
github-actions bot
added a commit
that referenced
this pull request
Mar 27, 2026
SHA: db1e51c Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #924
@fdwr please take a look.
Preview | Diff