Allow random colors in borderColor array#7
Merged
webmatze merged 2 commits intowebmatze:masterfrom Sep 24, 2016
Merged
Conversation
webmatze
approved these changes
Sep 24, 2016
Owner
webmatze
left a comment
There was a problem hiding this comment.
Looks great. Thank you for your contribution to hyperborder. I will add your comments to the README and then publish a new version later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there. First of all, good work on this fun little project!
I'm not sure if you're looking for these kinds of changes, but they enabled my to do what I wanted to do with this project.
Border settings this enables:
Of course, this breaks how
borderColors: 'random'worked previously, since that would create a gradient of two random colors, and now it would only be a single solid-color border.If it's preferable to keep that behavior,
line 8could be change to: