Fix preview image discrepancy in RD-mode#40
Merged
Conversation
Instead of passing around the selected batch as the reference batch when in absolute or RD-mode, leave the reference batch undefined to avoid wrongly referencing into the selected batch with rightIndex. When there is a reference: leftIndex points to selected row (correct) rightIndex points to reference row (correct) Otherwise, before this change: leftIndex pointed to selected row (correct) rightIndex pointed to selected row (which is wrongly indexed) Otherwise, after this change: leftIndex points to selected row (correct) rightIndex cannot point to undefined (caught by typescript) The data shown in the table was correct. Only some cell coloring and the preview image were sometimes stale.
maryla-uc
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of passing around the selected batch as the reference batch when in absolute or RD-mode, leave the reference batch undefined to avoid wrongly referencing into the selected batch with rightIndex.
When there is a reference:
leftIndex points to selected row (correct)
rightIndex points to reference row (correct)
Otherwise, before this change:
leftIndex pointed to selected row (correct)
rightIndex pointed to selected row (which is wrongly indexed)
Otherwise, after this change:
leftIndex points to selected row (correct)
rightIndex cannot point to undefined (caught by typescript)
The data shown in the table was correct. Only some cell coloring and the preview image were sometimes stale.