Working implementation of PDF.js backend#1
Merged
thz merged 4 commits intowebodf:masterfrom Jul 14, 2013
Merged
Conversation
PluginLoader overrides the PluginLoader in webodf with an extra entry for PDF files, and that's all. During building, the built viewer/ directory is copied from webodf to Viewer.js's build tree, and PluginLoader is overwritten with Viewer.js's copy.
thz
added a commit
that referenced
this pull request
Jul 14, 2013
Working implementation of PDF.js backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewer.js has a
PluginLoader.jswhich overrides thePluginLoader.jsof webodf's viewer (and that is the only thing that is overridden).At the moment it checks the extensions of the files passed in the hash, and decides the plugin to use.
My CMake skills are not good, but here's the general gist of it: