Skip to content

Also support DOCUMENT_FRAGMENT_NODE in UnitTester.#898

Merged
vandenoever merged 1 commit intowebodf:masterfrom
vandenoever:moreNodeTypes
Jun 1, 2015
Merged

Also support DOCUMENT_FRAGMENT_NODE in UnitTester.#898
vandenoever merged 1 commit intowebodf:masterfrom
vandenoever:moreNodeTypes

Conversation

@vandenoever
Copy link
Copy Markdown
Member

So far only text nodes and elements could be compared. With this patch
document fragments can also be compared.

@kogmbh-ci
Copy link
Copy Markdown

Build failed.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2367/

@vandenoever
Copy link
Copy Markdown
Member Author

retest this please

@kogmbh-ci
Copy link
Copy Markdown

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2369/

So far only text nodes and elements could be compared. With this patch
document fragments can also be compared.
@kogmbh-ci
Copy link
Copy Markdown

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2374/

@peitschie
Copy link
Copy Markdown
Contributor

Changes look fine to me. Assuming I still have the authority, please :shipit:!

vandenoever added a commit that referenced this pull request Jun 1, 2015
Also support DOCUMENT_FRAGMENT_NODE in UnitTester.
@vandenoever vandenoever merged commit bff40e6 into webodf:master Jun 1, 2015
@vandenoever
Copy link
Copy Markdown
Member Author

@peitschie thanks for the fast review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants