Skip to content

Conversation

@TerraSkye
Copy link

only uses current class to check for methods instead of all its parents.

only uses current class to check for methods instead of all its parents.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.493% when pulling 1e89fce on TerraSkye:patch-1 into 848f9c3 on webonyx:master.

@vladar
Copy link
Member

vladar commented May 5, 2017

Thanks for the suggested fix. But I think the better solution would be to just prefix resolvers method names with resolve (so that full method name became "resolve" . ucfirst($fieldName)). This is example after all, so I'd like to keep it clear for end-users what's going on.

If you agree to change the fix - I'd greatly appreciate your help!

@TerraSkye
Copy link
Author

I also saw that its not the only point the problem occurs. So it needs a bit more wurk

@vladar
Copy link
Member

vladar commented Jun 27, 2017

I fixed it in f668300

@vladar vladar closed this Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants