Skip to content

Fix native return typehint errors#647

Merged
simPod merged 7 commits intowebonyx:masterfrom
shmax:fix-native-return-typehint
Apr 28, 2020
Merged

Fix native return typehint errors#647
simPod merged 7 commits intowebonyx:masterfrom
shmax:fix-native-return-typehint

Conversation

@shmax
Copy link
Copy Markdown
Contributor

@shmax shmax commented Apr 19, 2020

This fixes about half of the "Anonymous function should have native return typehint" phpstan errors. If this PR goes through with no problem I'll tackle the rest in a second PR.

@shmax shmax closed this Apr 19, 2020
@shmax shmax reopened this Apr 19, 2020
Copy link
Copy Markdown
Collaborator

@simPod simPod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive!

Comment thread src/Validator/Rules/ProvidedRequiredArguments.php
Comment thread src/Validator/Rules/ProvidedRequiredArguments.php
Comment thread src/Validator/Rules/ProvidedRequiredArgumentsOnDirectives.php
Comment thread src/Validator/Rules/ValuesOfCorrectType.php
Comment thread phpstan-baseline.neon Outdated
Comment thread composer.json
Comment thread src/Language/AST/NamedTypeNode.php Outdated
@simPod simPod merged commit e1bce32 into webonyx:master Apr 28, 2020
@shmax shmax deleted the fix-native-return-typehint branch April 28, 2020 06:11
@shmax
Copy link
Copy Markdown
Contributor Author

shmax commented Apr 28, 2020

Thanks much for reviewing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants