Make type hint for OperationDefinitionNode#name nullable#653
Merged
simPod merged 2 commits intowebonyx:masterfrom Apr 27, 2020
spawnia:operations-may-be-unnamed
Merged
Make type hint for OperationDefinitionNode#name nullable#653simPod merged 2 commits intowebonyx:masterfrom spawnia:operations-may-be-unnamed
simPod merged 2 commits intowebonyx:masterfrom
spawnia:operations-may-be-unnamed
Conversation
Collaborator
Author
|
Those PHPStan baseline errors are giving me a headache. What's the recommended workflow for fixing them? |
Collaborator
|
New errors should be fixed and after that baseline needs to be regenerated. Maybe I'd fix those errors so they can be removed from baseline completely? |
simPod
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/webonyx/graphql-php/blob/master/src/Language/Parser.php#L505