Fix native return typehint pt ii#656
Merged
simPod merged 40 commits intowebonyx:masterfrom Apr 29, 2020
Merged
Conversation
simPod
approved these changes
Apr 29, 2020
Collaborator
|
I wonder whether we can also drop this now https://github.com/webonyx/graphql-php/blob/master/phpcs.xml.dist#L19? |
Co-Authored-By: Šimon Podlipský <simon@podlipsky.net>
…/shmax/graphql-php into fix-native-return-typehint-pt-ii
Contributor
Author
I don't know what that does--even with it enabled I was getting the errors. But I removed it, and everything still seems to check out. 🤷 Edit: oh, I get it--that's the code sniffer. I'd better put it back the way it was. I don't have the energy right now... |
This reverts commit 4dd0279.
Contributor
Author
|
@simPod Thanks for reviewing 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As promised, this is the second half of the "Anonymous function should have native return typehint..." phpstan fixes.