[Release 3.1.3] Add native_service for apollo, fixbug ares-setup-device device name with "-"#17
Conversation
added 3 commits
October 14, 2024 09:43
:Release Notes: Fix bug ares-setup-device device name with hyphen cannot be added/modified/removed/set default :Detailed Notes: - Fix bug that device naming start with hyphen (eg. "-abc") can be added/modified using CLI - Fix bug that device naming only with hyphens (eg. "--" or "---") can be added/modified/removed/set default using CLI :Testing Performed: 1. All unit tests passed 2. ESLint done 3. Check the below commands - $ares-setup-device --add/-a -abc -i "host=10.123.45.67" > New device with name "-abc" and OPTION has been added - $ares-setup-device --add/-a ---- -i "host=10.123.45.67" > New device with name "----" and OPTION has been added - $ares-setup-device --modify/-m -abc -i "host=10.123.45.67" > Information of the device with the name "-abc" has been changed - $ares-setup-device --modify/-m ---- -i "host=10.123.45.67" > Information of the device with the name "----" has been changed - $ares-setup-device --default/-f ---- > Set the device with the name "----" to be default - $ares-setup-device --remove/-r ---- > The device with name "----" has been removed :Issues Addressed: N/A
:Release Notes:
- ares-generate: new native service template for apollo profile
:Detailed Notes:
- Update apollo-sdk-template.json to support native-service template
- Add native-service template files: src/main.c, services.json, CMakeList.txt
:Testing Performed:
1. Checked CLI unit test
2. Checked API unit test
3. Checked eslint
4. Check ares-generate using below command
- $ares-config -p apollo
>profile and config data is changed to apollo
- $ares-generate -t native_service SERVICE_DIR
>Generating native_service in SERVICE_DIR
:Issues Addressed: N/A
Release Notes: - Update package version 3.1.3 and change log :Detailed Notes: - Update package.json for v3.1.3 - Update npm-shrinkwarp.json - Update CHANEGLOG.md for v3.1.3 :Testing Performed: 1. Checked CLI unit test 2. Checked eslint 3. Check the version using the below command - $ares -V >Version: 3.1.3 :Issues Addressed: N/A
Collaborator
|
It seems ok for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:Release Notes:
ares-generate: new native service template for apollo profile
ares-setup-device: fixed a bug that the device name can not be added with "-".
:Testing Performed:
:Issues Addressed: N/A