feat(addScript): disable 'use strict' to allow setting globals
#51
Conversation
|
Mike Enriquez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
@d3viant0ne @bebraw @SpaceK33z @TheLarkInn |
|
@timpur I think it's waiting for the author of this PR to accept the CLA. Otherwise the change cannot be merged in. |
|
Sorry, I’m not interested in signing. |
|
Hi @enriquez 👋👋👋👋 I'm Sean, from the webpack team. Is there any concerns that you have over the CLA that would make you hesitant to sign it? The CLA helps ensure that the IP rights of any contributors belong to the non-profit hosting webpack (in this case it is the JS Foundation). This is a protection that allows our ecosystem and code to be protected from patent fraud filings, as well as other legal issues, keeping our code free, open, and never moved to for-profit business license. If still you do not feel comfortable in signing. Really appreciate your quick response here! 🙇🙇🙇🙇🙇🙇🙇 |
|
3 PR's later i got it working -> #55 |
michael-ciniawsky
changed the title
'use strict' to allow setting globals
|
@enriquez Please sign the CLA and see #55 (comment) for initail discussion. I'm going to close this PR in favor of #55 within the next ~48-72 hours due to the missing CLA signment |
|
Feel free to reopen if the comments are addressed and the CLA is signed. Thx |
6 participants
I wasn't able to get some external scripts loaded into the global context since they're in strict mode. See http://whereswalden.com/2011/01/10/new-es5-strict-mode-support-new-vars-created-by-strict-mode-eval-code-are-local-to-that-code-only/