fix: missing options include && exclude#95
Merged
alexander-akait merged 1 commit intowebpack:masterfrom Jan 29, 2018
Merged
Conversation
|
|
michael-ciniawsky
changed the title
include && exclude options (this.options)
alexander-akait
approved these changes
Jan 29, 2018
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Thanks, please accept CLA 👍
Contributor
Author
|
Hi @evilebottnawi, the CLA is marked as signed when I click on details. I believe something is wrong with the check. |
michael-ciniawsky
changed the title
include && exclude options (this.options)include && exclude
Contributor
|
Released in v1.1.4 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IssuesNotable ChangesI also ran into the above issue and confirmed that ModuleFilenameHelpers.matchObject does not get an options object with either include or exclude. They were not getting passed to the internal options object. I removed the regExp option because I'm assuming that it was mistakenly added, as there's no reference to one in the project documentation and it's the typename for the test/include/exclude options.
Reproductionhttps://github.com/Stavrus/wpctest