Skip to content

fix(lib): rm comment, rename const => var #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-ciniawsky merged 3 commits into from
Mar 12, 2017
Merged

fix(lib): rm comment, rename const => var #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2201dcb
chore(package): rm convert-source-map
michael-ciniawsky Mar 12, 2017
0893c3f
fix(lib/convert-source-map): rm comment
michael-ciniawsky Mar 12, 2017
0c77ea5
fix(lib/css-base): rename const => var
michael-ciniawsky Mar 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/convert-source-map.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ var path = require('path');

var commentRx = /^\s*\/(?:\/|\*)[@#]\s+sourceMappingURL=data:(?:application|text)\/json;(?:charset[:=]\S+?;)?base64,(?:.*)$/mg;
var mapFileCommentRx =
//Example (Extra space between slashes added to solve Safari bug. Exclude space in production):
// / /# sourceMappingURL=foo.js.map /*# sourceMappingURL=foo.js.map */
/(?:\/\/[@#][ \t]+sourceMappingURL=([^\s'"]+?)[ \t]*$)|(?:\/\*[@#][ \t]+sourceMappingURL=([^\*]+?)[ \t]*(?:\*\/){1}[ \t]*$)/mg

function decodeBase64(base64) {
Expand Down
2 changes: 1 addition & 1 deletion lib/css-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = function() {
// return the list of modules as css string
list.toString = function toString() {
return this.map(function (item) {
const content = cssWithMappingToString(item);
var content = cssWithMappingToString(item);
if(item[2]) {
return "@media " + item[2] + "{" + content + "}";
} else {
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
],
"dependencies": {
"babel-code-frame": "^6.11.0",
"convert-source-map": "^1.3.0",
"css-selector-tokenizer": "^0.7.0",
"cssnano": ">=2.6.1 <4",
"loader-utils": "^1.0.2",
Expand Down