Skip to content

fix: move join/dirname caches to Resolver instance to prevent memory leak#507

Open
xiaoxiaojx wants to merge 1 commit intomainfrom
fix/join-cache-memory-leak
Open

fix: move join/dirname caches to Resolver instance to prevent memory leak#507
xiaoxiaojx wants to merge 1 commit intomainfrom
fix/join-cache-memory-leak

Conversation

@xiaoxiaojx
Copy link
Copy Markdown
Member

Summary
fixes #414

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Existing

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing

Use of AI
Partial

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 5, 2026

🦋 Changeset detected

Latest commit: fd07044

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
enhanced-resolve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Apr 5, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xiaoxiaojx / name: xiaoxiaojx (fd07044)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (986a974) to head (fd07044).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   93.42%   93.51%   +0.08%     
==========================================
  Files          50       50              
  Lines        2525     2543      +18     
  Branches      773      776       +3     
==========================================
+ Hits         2359     2378      +19     
+ Misses        137      136       -1     
  Partials       29       29              
Flag Coverage Δ
integration 93.51% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xiaoxiaojx xiaoxiaojx marked this pull request as draft April 5, 2026 12:58
@xiaoxiaojx xiaoxiaojx force-pushed the fix/join-cache-memory-leak branch from 724f707 to fd07044 Compare April 5, 2026 13:12
@xiaoxiaojx xiaoxiaojx marked this pull request as ready for review April 5, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pathUtils | joinCache memory leak

1 participant