feat: add promise API for resolve#520
Merged
alexander-akait merged 6 commits intomainfrom Apr 15, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: d0083bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
+ Coverage 92.68% 93.57% +0.88%
==========================================
Files 50 50
Lines 2555 2582 +27
Branches 779 785 +6
==========================================
+ Hits 2368 2416 +48
+ Misses 157 137 -20
+ Partials 30 29 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add `resolve.promise` and `resolve.create.promise` that return a `Promise<string | false>` instead of using a callback, complementing the existing callback (`resolve`) and sync (`resolve.sync`) APIs.
Add a `resolvePromise` method to the `Resolver` class that returns a `Promise<string | false>`, mirroring the existing `resolveSync` method. The module-level `resolve.promise` and `resolve.create.promise` APIs now delegate to it.
alexander-akait
force-pushed
the
claude/implement-promise-api-g0tLD
branch
from
e671b53 to
fcf99c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
resolve.promiseandresolve.create.promisethat return aPromise<string | false>instead of using a callback, complementingthe existing callback (
resolve) and sync (resolve.sync) APIs.fixes #309