Skip to content

Fix use basename helper everywhere#538

Merged
alexander-akait merged 2 commits intomainfrom
fix-use-basename-helper-everywhere
Apr 17, 2026
Merged

Fix use basename helper everywhere#538
alexander-akait merged 2 commits intomainfrom
fix-use-basename-helper-everywhere

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

Summary

fix

What kind of change does this PR introduce?

fix

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Nothing

Use of AI

No

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 17, 2026

⚠️ No Changeset found

Latest commit: a8b2f06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.44%. Comparing base (8710f19) to head (a8b2f06).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   96.45%   96.44%   -0.02%     
==========================================
  Files          50       50              
  Lines        2678     2669       -9     
  Branches      814      812       -2     
==========================================
- Hits         2583     2574       -9     
  Misses         80       80              
  Partials       15       15              
Flag Coverage Δ
integration 96.44% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2026

Merging this PR will improve performance by 14.54%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 66 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
realistic-midsize: mixed batch (cold cache) 8.2 ms 7.2 ms +14.54%

Comparing fix-use-basename-helper-everywhere (a8b2f06) with main (8710f19)

Open in CodSpeed

@alexander-akait alexander-akait merged commit 1c52e71 into main Apr 17, 2026
34 checks passed
@alexander-akait alexander-akait deleted the fix-use-basename-helper-everywhere branch April 17, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant