default minification settings are dangerous

[mkoryak]

By default, this plugin will blow away 'redundant' attributes. This means that it will remove type='text' from an input. This is bad because it breaks styles, and potentially javascript etc.

The html minifier you use has settings that it calls "safe", you should default to those at most.

[thelinuxlich]

+1 this is horrible

[mkoryak]

it would be less horrible if it was documented. would you like a PR for that?

[chrisnicola]

Ran into this as well, adding ?removeRedundantAttributes=false to the query fixes it. It probably should be set this way by default though and the minification options of the HTML minifier should be documented somewhere. Took me a while to track the cause of this down.

[jantimon]

Got the same problem with removeOptionalTags: #40

[chrisnicola]

@jantimon what does removeOptionalTags break?

[mkoryak]

@chrisnicola
it will break this css

[type="text"] {
   background-color: red;
}

or this js

$('[type="text"]').on('click', function(){ alert('poop'); });

Also any other code that relies on anything this thing will remove.

you get the idea.

edit: just noticed you asked about removeOptionalTags, but the issue is the same, just replace my attribute selector with a tag that will be removed

[chrisnicola]

Optional tags just removes closing and a few other tags. I think you are talking about removeDefaultAttributes

[mkoryak]

Nice, it looks fixed.

FYI, you don't need to use typeof to compare something to undefined. It was a thing people did when one could reassign undefined. You can just do if (thing === undefined) and it works great.

Same for most other comparisons. Some of them use typeof because of iframe issues etc. You dont have those here.