docs(readme): restore extract-loader usage #459
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs mention the use of `extract-loader`, but the example which mentions it does not actually use it. This appears to be an unintentional change made as part of webpack#423, as that pull request does not mention any intent to change the docs.
|
|
snitin315
reviewed
Oct 6, 2022
| { | ||
| test: /\.html$/i, | ||
| use: ["html-loader"], | ||
| use: ["extract-loader", "html-loader"], |
Member
There was a problem hiding this comment.
It was removed from two places, can you add the other one as well??
Codecov ReportBase: 92.20% // Head: 92.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 92.20% 92.20%
=======================================
Files 7 7
Lines 590 590
Branches 190 190
=======================================
Hits 544 544
Misses 37 37
Partials 9 9 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
Sorry for delay, close because of #404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
The docs mention the use of
extract-loader, but the example which mentions it does not actually use it. This appears to be an unintentional change made as part of #423, as that pull request does not mention any intent to change the docs.Additional Info
I tested the example configuration using webpack 5, html-loader v4.1.0, and extract-loader v5.1.0.