adds "exportAsDefault" #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
4 tasks
Current coverage is 96.80% (diff: 100%)@@ master #99 diff @@
==========================================
Files 2 2
Lines 90 94 +4
Methods 11 11
Messages 0 0
Branches 16 17 +1
==========================================
+ Hits 87 91 +4
Misses 3 3
Partials 0 0
|
Contributor
Author
|
@hemanth, pls take a look |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior?
currently we have 2 export formats: cjs (
module.exports =, which is default), and "es6to5" (exports.default =, whenexportAsEs6Defaultparam is set)What is the new behavior?
this PR changes behavior of
exportAsEs6Defaultparam to actually export ES6 default export:exports default "hello world";, and brings in another param (exportAsDefault) to export in es6to5 format:exports.default = "hello world";Does this PR introduce a breaking change?