refactor: apply webpack-defaults #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to test/helpers/createSpec.js. We are going to use ava and ava will ignore folders that are called "helpers" by default.
Less' internal file structure might change, but npm's is more stable.
Folders named "fixtures" are ignored by ava.
- Remove bootstrap. It's just big but adds almost now value to the tests. - Move test node_modules into fixtures folder
- Do not use Less stdin since it produces wrong paths in some scenarios - Add configurable lessOptions for each test id - Fix linting errors
Codecov Report
@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 92.72% 93.22% +0.49%
==========================================
Files 2 2
Lines 55 59 +4
Branches 0 9 +9
==========================================
+ Hits 51 55 +4
Misses 4 4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds all the tooling from webpack-defaults and simplifies the tests a little bit (it basically removes bootstrap as test fixture which is big but adds no additional value). It's the first step of a major refactoring.