Skip to content

Conversation

@mattlewis92
Copy link
Member

@mattlewis92 mattlewis92 commented Jul 20, 2017

Now node 8.2 is stable these hacks I added in #208 can be removed. Doing npm i on a fresh checkout of the repo somehow updated the package-lock as well which was a bit odd.

edit: looks like appveyor is still on node 8.1 which has the buggy npm 5.0.x, will have to wait a bit for them to upgrade. Can use https://www.appveyor.com/updates/ for tracking when node 8.2.x is added.

@alexander-akait
Copy link
Member

@mattlewis92 seems it is already fixed into webpack-defaults, maybe just update to latest webpack-defaults?

@mattlewis92
Copy link
Member Author

@evilebottnawi this package is on the latest webpack-defaults, this PR is undoing some extra changes I added to get the CI to pass (as the npm version bundled with node 8.1 was super buggy), however node 8.2 with npm 5.3.0 is now out so these hacks aren't needed anymore.

@mattlewis92 mattlewis92 reopened this Jul 20, 2017
@codecov
Copy link

codecov bot commented Jul 20, 2017

Codecov Report

Merging #212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #212   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files           8        8           
  Lines          93       93           
  Branches        9        9           
=======================================
  Hits           91       91           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec229d9...e477939. Read the comment docs.

Copy link
Member

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when appveyor has node updated aswell :)

@joshwiens
Copy link
Member

Appveyor....where latest isn't actually latest

@mattlewis92
Copy link
Member Author

Looking at their update history, it's probably going to be another month before they add node 8.2 😕

@mattlewis92 mattlewis92 reopened this Aug 25, 2017
@joshwiens joshwiens changed the title chore: remove npm CI hacks chore: Update to webpack-defaults 1.6 Oct 5, 2017
@joshwiens joshwiens merged commit b6d0478 into master Oct 5, 2017
@joshwiens joshwiens deleted the remove-npm-ci-hack branch October 5, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants