-
-
Notifications
You must be signed in to change notification settings - Fork 197
chore: Update to webpack-defaults 1.6 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mattlewis92 seems it is already fixed into |
|
@evilebottnawi this package is on the latest webpack-defaults, this PR is undoing some extra changes I added to get the CI to pass (as the npm version bundled with node 8.1 was super buggy), however node 8.2 with npm 5.3.0 is now out so these hacks aren't needed anymore. |
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 8 8
Lines 93 93
Branches 9 9
=======================================
Hits 91 91
Misses 2 2Continue to review full report at Codecov.
|
michael-ciniawsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 when appveyor has node updated aswell :)
|
Appveyor....where |
|
Looking at their update history, it's probably going to be another month before they add node 8.2 😕 |
aeeef5f to
a582f80
Compare
Now node 8.2 is stable these hacks I added in #208 can be removed. Doing
npm ion a fresh checkout of the repo somehow updated the package-lock as well which was a bit odd.edit: looks like appveyor is still on node 8.1 which has the buggy npm 5.0.x, will have to wait a bit for them to upgrade. Can use https://www.appveyor.com/updates/ for tracking when node 8.2.x is added.