Remove peerDependency on Webpack

[mattvagni]

I'm currently using mini-css-extract-plugin within an NPM dependency and am running into issues due to it specifying Webpack as a peerDependency. NPM unfortunately hoists it to the root where the Webpack version may be different per project.

I was wondering how come I don't have this issue with style-loader and other popular loaders and noticed that they don't seem to specify a peer on Webpack at all.

Could we make the same change here? I'd be happy to open a PR if you think this is ok. I realise this is not an issue per se with mini-css-extract-plugin so I thought I'd open an issue first.

Thanks

[alexander-akait]

All loaders and plugins should use webpack in peerDependencies to avoid problems with compatibility with difference versions. In near future style-loader/css-loader will receive update with peerDependencies. Also webpack should be on top of your mode_modules (just add webpack to your package.json).

[mattvagni]

Hi @evilebottnawi I'm curious as to what you'd suggest for my use-case.

I have an npm package that uses webpack as regular dependency. It's something akin to https://github.com/storybooks/storybook . The problem I am having is with NPM's long-standing issue with how peer dependency are hoisted.

What is happening is that it unfortunately hoists mini-css-extract-plugin to the root and if the project has a different Webpack version installed it will result in that version being used vs. the webpack version specified in my npm module.

Could I suggest instead of using peerDependencies that loaders and plugins instead specify a ranged normal dependency. i.e "webpack": ">=4 < 5" ? That way the correct webpack version will definitely be used and NPM will/should remove duplicates.

In any case I've solved this issue for myself by not using mini-css-extract-plugin at all for now. So this is not urgent.