Skip to content

refactor: do not validate postcss options #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020
Merged

refactor: do not validate postcss options #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions src/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,49 +20,6 @@
"type": "boolean"
}
]
},
"parser": {
"description": "Allows to specify custom Postcss Parser (https://github.com/postcss/postcss-loader#parser)",
"anyOf": [
{
"type": "string"
},
{
"type": "object"
},
{
"instanceof": "Function"
}
]
},
"syntax": {
"description": "Allows to specify custom Postcss Syntax (https://github.com/postcss/postcss-loader#syntax)",
"anyOf": [
{
"type": "string"
},
{
"type": "object"
}
]
},
"stringifier": {
"description": "Allows to specify custom Postcss stringifier (https://github.com/postcss/postcss-loader#stringifier)",
"anyOf": [
{
"type": "string"
},
{
"type": "object"
},
{
"instanceof": "Function"
}
]
},
"plugins": {
"description": "Sets PostCSS Plugins (https://github.com/postcss/postcss-loader#plugins)",
"anyOf": [{ "type": "array" }, { "type": "object" }]
}
}
},
Expand Down
209 changes: 10 additions & 199 deletions test/__snapshots__/validate-options.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ exports[`validate options should throw an error on the "execute" option with "te
exports[`validate options should throw an error on the "postcssOptions" option with "{"config":[]}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
object { config?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.config should be one of these:
Expand All @@ -52,209 +52,20 @@ exports[`validate options should throw an error on the "postcssOptions" option w
-> Enables/Disables autoloading config"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"parser":[]}" value 1`] = `
exports[`validate options should throw an error on the "postcssOptions" option with "{"config":{}}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
object { config?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.parser should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss Parser (https://github.com/postcss/postcss-loader#parser)
Details:
* options.postcssOptions.parser should be a string.
* options.postcssOptions.parser should be an object:
object { … }
* options.postcssOptions.parser should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"parser":1}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.parser should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss Parser (https://github.com/postcss/postcss-loader#parser)
Details:
* options.postcssOptions.parser should be a string.
* options.postcssOptions.parser should be an object:
object { … }
* options.postcssOptions.parser should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"parser":true}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.parser should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss Parser (https://github.com/postcss/postcss-loader#parser)
Details:
* options.postcssOptions.parser should be a string.
* options.postcssOptions.parser should be an object:
object { … }
* options.postcssOptions.parser should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"plugins":"postcss-short"}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.plugins should be one of these:
[any, ...] | object { … }
-> Sets PostCSS Plugins (https://github.com/postcss/postcss-loader#plugins)
Details:
* options.postcssOptions.plugins should be an array:
[any, ...]
* options.postcssOptions.plugins should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"plugins":1}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.plugins should be one of these:
[any, ...] | object { … }
-> Sets PostCSS Plugins (https://github.com/postcss/postcss-loader#plugins)
Details:
* options.postcssOptions.plugins should be an array:
[any, ...]
* options.postcssOptions.plugins should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"plugins":true}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.plugins should be one of these:
[any, ...] | object { … }
-> Sets PostCSS Plugins (https://github.com/postcss/postcss-loader#plugins)
Details:
* options.postcssOptions.plugins should be an array:
[any, ...]
* options.postcssOptions.plugins should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"stringifier":[]}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.stringifier should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss stringifier (https://github.com/postcss/postcss-loader#stringifier)
Details:
* options.postcssOptions.stringifier should be a string.
* options.postcssOptions.stringifier should be an object:
object { … }
* options.postcssOptions.stringifier should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"stringifier":1}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.stringifier should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss stringifier (https://github.com/postcss/postcss-loader#stringifier)
Details:
* options.postcssOptions.stringifier should be a string.
* options.postcssOptions.stringifier should be an object:
object { … }
* options.postcssOptions.stringifier should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"stringifier":true}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.stringifier should be one of these:
string | object { … } | function
-> Allows to specify custom Postcss stringifier (https://github.com/postcss/postcss-loader#stringifier)
Details:
* options.postcssOptions.stringifier should be a string.
* options.postcssOptions.stringifier should be an object:
object { … }
* options.postcssOptions.stringifier should be an instance of function."
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"syntax":[]}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.syntax should be one of these:
string | object { … }
-> Allows to specify custom Postcss Syntax (https://github.com/postcss/postcss-loader#syntax)
Details:
* options.postcssOptions.syntax should be a string.
* options.postcssOptions.syntax should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"syntax":1}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.syntax should be one of these:
string | object { … }
-> Allows to specify custom Postcss Syntax (https://github.com/postcss/postcss-loader#syntax)
Details:
* options.postcssOptions.syntax should be a string.
* options.postcssOptions.syntax should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{"syntax":true}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.syntax should be one of these:
string | object { … }
-> Allows to specify custom Postcss Syntax (https://github.com/postcss/postcss-loader#syntax)
Details:
* options.postcssOptions.syntax should be a string.
* options.postcssOptions.syntax should be an object:
object { … }"
`;

exports[`validate options should throw an error on the "postcssOptions" option with "{}" value 1`] = `
"Invalid options object. PostCSS Loader has been initialized using an options object that does not match the API schema.
- options.postcssOptions should be one of these:
object { config?, parser?, syntax?, stringifier?, plugins?, … } | function
-> Options to pass through to \`Postcss\`.
Details:
* options.postcssOptions.plugins should be one of these:
[any, ...] | object { … }
-> Sets PostCSS Plugins (https://github.com/postcss/postcss-loader#plugins)
* options.postcssOptions.config should be one of these:
string | boolean
-> Allows to specify PostCSS Config Path (https://github.com/postcss/postcss-loader#config)
Details:
* options.postcssOptions.plugins should be an array:
[any, ...]
* options.postcssOptions.plugins should be an object:
object { … }"
* options.postcssOptions.config should be a string.
-> Allows to specify the path to the configuration file
* options.postcssOptions.config should be a boolean.
-> Enables/Disables autoloading config"
`;

exports[`validate options should throw an error on the "sourceMap" option with "/test/" value 1`] = `
Expand Down
21 changes: 1 addition & 20 deletions test/validate-options.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,26 +44,7 @@ describe('validate options', () => {
),
},
],
failure: [
{ parser: 1 },
{ parser: true },
{ parser: [] },
{ syntax: 1 },
{ syntax: true },
{ syntax: [] },
{ stringifier: 1 },
{ stringifier: true },
{ stringifier: [] },
{ plugins: 1 },
{ plugins: true },
{ plugins: 'postcss-short' },
{
plugins: () => {
return [];
},
},
{ config: [] },
],
failure: [{ config: [] }, { config: /test/ }],
},
sourceMap: {
success: [true, false],
Expand Down