feat: add api "auto" and use it by default#1319
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: b5a1a28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
When the resolved Sass implementation exposes `initAsyncCompiler`, `auto` picks the modern-compiler API (which reuses a single long-running compiler across files); otherwise it falls back to the modern API. The default value of the `api` option is now `auto`, so `sass` and `sass-embedded` users get the modern-compiler speedup out of the box without any configuration. https://claude.ai/code/session_01Php4VTSCnDbpbh7BgJxPud
Drops the nested-ternary at the call site by letting `getCompileFn` default `apiType` to `"auto"` and treat it the same as `"modern-compiler"` when the implementation exposes `initAsyncCompiler`. https://claude.ai/code/session_01Php4VTSCnDbpbh7BgJxPud
alexander-akait
force-pushed
the
claude/auto-api-async-compiler-OYfgF
branch
2 times, most recently
from
c02bb92 to
f350c6e
Compare
alexander-akait
force-pushed
the
claude/auto-api-async-compiler-OYfgF
branch
from
f350c6e to
d97cf9d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
+ Coverage 92.30% 92.35% +0.05%
==========================================
Files 3 3
Lines 299 301 +2
Branches 104 106 +2
==========================================
+ Hits 276 278 +2
Misses 20 20
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fixes pre-existing `unicorn/no-array-sort` lint errors so the lint job stays clean. https://claude.ai/code/session_01Php4VTSCnDbpbh7BgJxPud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the resolved Sass implementation exposes
initAsyncCompiler,autopicks the modern-compiler API (which reuses a single long-runningcompiler across files); otherwise it falls back to the modern API. The
default value of the
apioption is nowauto, sosassandsass-embeddedusers get the modern-compiler speedup out of the boxwithout any configuration.
https://claude.ai/code/session_01Php4VTSCnDbpbh7BgJxPud