Making node-sass a fully-fledged dependency

[stevemao]

In npm3, peerDeps aren't auto-installed anymore.

[jhnns]

Sorry, specifying node-sass as peerDependency is far more useful for most users.

Since node-sass/libsass processes your files, you should be able to specify the exact version you need. The sass-loader is just using an API which is not affected by most changes.

In other words: Your API surface to node-sass is much bigger than ours. Otherwise we would have tons of issues and PRs like "Update node-sass to x.y.z plz"

[stevemao]

I'm using npm3 now and it doesn't install node-sass automatically.

[stevemao]

Also I think this is the same with any other wrappers. You could keep the same semver as node-sass, you could lock the version of it if there is any bug etc. If there is an API breaking change in node-sass your module would not break for people before you bump it and make the changes. I could give you a ton of projects that do it.

[jhnns]

I'm using npm3 now and it doesn't install node-sass automatically.

I know and that's good. node-sass should be the dependency of your project.

I could give you a ton of projects that do it.

It's true, people are handling this differently. And while there are projects where your suggested approach is very reasonable (like for the phantomjs-package for example), I don't think that it fits here.

The sass-loader is a link between webpack and node-sass. Following node-sass versions would ignore the fact that we also have to stay up-to-date with webpack: So, which version number should we follow then? Imho, the most robust solution to this problem is to have an own version number and to specify both as peerDependency.

But you're right. I forgot to add webpack as peerDependency. 😁

[stevemao]

Hmm... I don't know if this is the recommended approach. @iarna and @othiym23 may know more details. :)

[jhnns]

I would love to hear alternatives from @iarna or @othiym23, but I guess there no new insights than already discussed at npm/npm#5080 npm/npm#6565 npm/npm#7495...

[stevemao]

hm..alright..