feat: Add the ability to pass in a custom resolver #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
=========================================
+ Coverage 98.06% 98.1% +0.03%
=========================================
Files 6 6
Lines 155 158 +3
=========================================
+ Hits 152 155 +3
Misses 3 3
Continue to review full report at Codecov.
|
alexander-akait
requested changes
May 13, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
One note, anyway thanks for work
voom-pairing-helionix
force-pushed
the
resolver-option
branch
from
b8eb311 to
2efeab9
Compare
hjhart
changed the title
- Also add the ability to disable the default resolver to fall through to node-sass
voom-pairing-helionix
force-pushed
the
resolver-option
branch
from
2efeab9 to
6b27d26
Compare
6 tasks
|
@evilebottnawi Is there anything we need to complete on our end to get this merged in? Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to node-sass
This PR contains a:
Motivation / Use-Case
To be able to provide a custom resolver to sass-loader. See this pull request for more discussion which led to this pull request:
Breaking Changes
Not a breaking change
Additional Info